Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor publication type validation #842

Merged
merged 65 commits into from
Jan 18, 2023
Merged

Refactor publication type validation #842

merged 65 commits into from
Jan 18, 2023

Conversation

caendesilva
Copy link
Member

No description provided.

caendesilva and others added 18 commits January 18, 2023 14:02
@caendesilva
Restructure buffering to flatten internal array
9b7d3cf
@caendesilva
Create ValidatesPublicationSchema.php
865c4b9
@caendesilva
Create ValidatesPublicationSchemaTest.php
bcfdc1f
@caendesilva
Create constructor
0c4e7b6
@caendesilva
Add array as the invoke function's return type
b798a40
@caendesilva
Change property type array to stdClass
779686c
@caendesilva
Extract logic to invokable action class
94b5edc
@caendesilva
Move tests for moved code from service to action
a54b4c0
@caendesilva
Inline and remove method PublicationService::validateSchemaFile
88f81dd
@caendesilva
Deprecate throw parameter
bc70705
@caendesilva
Replace boolean argument with fluent helper methods
b50f310
@caendesilva
Add rich type annotations
53a6940
@StyleCIBot
Apply fixes from StyleCI
30a4a19
@caendesilva
Merge branch 'publications-feature' into refactor-publication-type-va…
3e7e087 
…lidation
@caendesilva
Allow null return type as it's depends on supplied parameter value
7ca3d75
@caendesilva
Call the fluent errors method to get the errors
50c3260
@caendesilva
Use all instead of toArray for a more compact format
5bb0c74 
The array keys provide no additional information
@caendesilva
Add type check to ensure property is an array before looping through it
66feecf
@caendesilva caendesilva force-pushed the refactor-publication-type-validation branch from 63240b5 to 66feecf Compare January 18, 2023 13:53
@codecov
Copy link

codecov bot commented Jan 18, 2023 •
edited
Loading

Codecov Report

Merging #842 (95b1fd4) into publications-feature (858469c) will not change coverage.
The diff coverage is n/a.

@@                   Coverage Diff                    @@
##             publications-feature      #842   +/-   ##
========================================================
  Coverage                  100.00%   100.00%           
- Complexity                   1585      1595   +10     
========================================================
  Files                         172       173    +1     
  Lines                        3954      3960    +6     
========================================================
+ Hits                         3954      3960    +6
Impacted Files Coverage Δ
...p/packages/publications/src/PublicationService.php 100.00% <0.00%> (ø)
...ckages/publications/src/Models/PublicationType.php 100.00% <0.00%> (ø)
...s/src/Commands/ValidatePublicationTypesCommand.php 100.00% <0.00%> (ø)
...ications/src/Actions/ValidatesPublicationField.php
...cations/src/Actions/PublicationSchemaValidator.php 100.00% <0.00%> (ø)
...ications/src/Actions/PublicationFieldValidator.php 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

caendesilva and others added 27 commits January 18, 2023 18:31
@caendesilva
Revert "Revert "Add array for warnings""
2fb3c26 
This reverts commit d571f0b.
@caendesilva
Remove warnings from action as they add too much complexity
da3c988 
These proposed warnings pretty much all only kick in if the user does something that goes against the defaults (and in some cases common sense) and that that point I think it's fair enough if the developer needs to do a tiny bit of debugging. Adding dynamic checks like tagGroup validation and similar add an unjustified amount of complexity at this point in time.
@caendesilva
Introduce local variables
4f3e300
@caendesilva
Bring variable static declaration out of loop
3ffb756
@caendesilva
Assemble the input array dynamically
ff605f8
@caendesilva
Inline local variable
ed5a615
@caendesilva
Replace foreach loop with collection mapper
ab3bd31
@caendesilva
Revert "Replace foreach loop with collection mapper"
7e0791b 
This reverts commit ab3bd31.
@caendesilva
Pluralize helper method name
53362e6
@caendesilva
Remove extra newline
b779fb7
@caendesilva
Convert internal collection representation to array so it can be pre-…
2ac726b 
…initialized
@caendesilva
Extract helper method
77c6df2
@caendesilva
Convert arrow function to a traditional closure
47d11fa
@caendesilva
Change closure to void
2266083
@caendesilva
Replace collection eacher with foreach loop
5df693a
@caendesilva
Extract method for repeated code
1b9875a
@caendesilva
Convert foreach loop to collect mapper
37ca029
@caendesilva
Convert closure to arrow function
6b01eae
@caendesilva
Revert "Convert closure to arrow function"
cc23e0d 
This reverts commit 6b01eae.
@caendesilva
Rename parameter to be more generic
a0c681a
@caendesilva
Inline local variables
1e988a7
@caendesilva
Extract method for repeated code
840ec9d
@StyleCIBot
Apply fixes from StyleCI
2b1b7f6
@caendesilva
Initialize the array
f5266b0
@caendesilva
Clean up class properties
837040a
@caendesilva
Rename class ValidatesPublicationField to PublicationFieldValidator
5c221c0
@caendesilva
Rename class ValidatesPublicationSchema to PublicationSchemaValidator
95b1fd4
@caendesilva caendesilva marked this pull request as ready for review January 18, 2023 19:12
@caendesilva caendesilva merged commit 99d09f7 into publications-feature Jan 18, 2023
@caendesilva caendesilva deleted the refactor-publication-type-validation branch January 18, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caendesilva @StyleCIBot