Add type check to ensure property is an array before looping through it

hydephp · Jan 18, 2023 · 66feecf · 66feecf
1 parent 5bb0c74
commit 66feecf
Showing 1 changed file with 16 additions and 14 deletions.
diff --git a/packages/publications/src/Actions/ValidatesPublicationSchema.php b/packages/publications/src/Actions/ValidatesPublicationSchema.php
@@ -65,20 +65,22 @@ public function __invoke(): static
 
         // TODO warn if pageSize is less than 0 (as that equals no pagination)?
 
-        foreach ($schema->fields as $field) {
-            // TODO check tag group exists?
-
-            $this->fieldValidators->add(validator([
-                'type' => $field->type ?? null,
-                'name' => $field->name ?? null,
-                'rules' => $field->rules ?? null,
-                'tagGroup' => $field->tagGroup ?? null,
-            ], [
-                'type' => 'required|string',
-                'name' => 'required|string',
-                'rules' => 'nullable|array',
-                'tagGroup' => 'nullable|string',
-            ]));
+        if (is_array($schema->fields)) {
+            foreach ($schema->fields as $field) {
+                // TODO check tag group exists?
+
+                $this->fieldValidators->add(validator([
+                    'type' => $field->type ?? null,
+                    'name' => $field->name ?? null,
+                    'rules' => $field->rules ?? null,
+                    'tagGroup' => $field->tagGroup ?? null,
+                ], [
+                    'type' => 'required|string',
+                    'name' => 'required|string',
+                    'rules' => 'nullable|array',
+                    'tagGroup' => 'nullable|string',
+                ]));
+            }
         }
 
         return $this;