Add a pagination component #832
Commits on Jan 13, 2023
-
-
-
-
Revert "Add pagination settings getter"
This reverts commit 475996a.
-
-
-
-
-
-
-
-
-
-
Change public generator to protected void and run it in constructor
This simplifies the class usage, and since the class is completely useless before generation there is no reason the developer should have to call the method manually.
-
Refactor class to be publication type agnostic
Hopefully this class can be used outside of publications as well
-
-
-
-
-
-
-
-
-
Rename method pagesTotal to totalPages
Breaks with the Laravel naming rules in favour of fluency
-
-
-
-
-
-
-
-
-
-
-
Unwrap key from loop as that resets indexing
Otherwise we need an offset so the list starts at one
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Rename method itemsStartNumber to firstItemNumberOnPage
Thanks ChatGPT for suggesting it!
-
-
-
-
Revert "Rename method to lastNumber"
This reverts commit 0275bf1.
-
Remove the itemsTotal method to reduce premature class bloat
And it's really simple to implement without extensions when needed.
-
Rename traversal question methods
Yes, this is very "left-to-right" centric, but so is the code. I'm going for clarity here, and if/when we add support for RTL this is not the place to start. I use LTR, so that's what I'm doing. Open to discussion and collaboration, but like I said, this is not the place to start.
-
-
-
-
-
Change previous/next methods to return link instead number to match r…
…oute because that just makes sense
-
-
-
-
-
-
-
-
-
-
Rename method getPaginatedPageCollection to getPaginatedCollection to…
… reduce confusion between other usages of the word page
-
-
-
-
-
Revert "Rename internal property $chunks to $items"
This reverts commit cddc353.
-
-
-
-
-
-
Remove pagination prefix from internal pagination class property
Because redundant
-
...that is useless in it self (hence why it's not public like the lastPage method) but makes the overall code readable as it's easier to visually diff differences
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Change public generator to protected void and run it in constructor
This simplifies the class usage, and since the class is completely useless before generation there is no reason the developer should have to call the method manually.
-
-
-
-
Refactor class to be publication type agnostic
Hopefully this class can be used outside of publications as well
-
Refactor to use simple array instead of full files for mocked data
Saving about 80ms per test run (now 0.001ms) without affecting the outcome of the test
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Revert "Inline local test variables"
This reverts commit b129b6b.
-
-
-
Rename traversal question methods
Yes, this is very "left-to-right" centric, but so is the code. I'm going for clarity here, and if/when we add support for RTL this is not the place to start. I use LTR, so that's what I'm doing. Open to discussion and collaboration, but like I said, this is not the place to start.
-
Rename method getPaginatedPageCollection to getPaginatedCollection to…
… reduce confusion between other usages of the word page
-
-
-
-
-
-
-
-
Commits on Jan 14, 2023
-
-
Update paginator to fall back to route basename prefixed string even …
…if there are no routes This means that if you set a route prefix to posts, links will be generated as posts/page-1.html, even if the route does not exist. This allows the pagination links to be generated outside of the kernel (such as in a post build task)
-