Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pagination feature to publications #814

Merged
merged 221 commits into from
Jan 8, 2023
Merged

Add pagination feature to publications #814

merged 221 commits into from
Jan 8, 2023

Conversation

caendesilva
Copy link
Member

Integrates working changes from #808

@codecov
Copy link

codecov bot commented Jan 6, 2023 •
edited
Loading

Codecov Report

Merging #814 (fd16723) into publications-feature (e5fc0fc) will decrease coverage by 0.53%.
The diff coverage is n/a.

❗ Current head fd16723 differs from pull request most recent head 1d76f96. Consider uploading reports for the commit 1d76f96 to get more accurate results

@@                    Coverage Diff                     @@
##             publications-feature     #814      +/-   ##
==========================================================
- Coverage                  100.00%   99.46%   -0.54%     
+ Complexity                   2930     1508    -1422     
==========================================================
  Files                         336      169     -167     
  Lines                        7348     3769    -3579     
==========================================================
- Hits                         7348     3749    -3599     
- Misses                          0       20      +20
Impacted Files Coverage Δ
...ckages/framework/src/Foundation/PageCollection.php 82.69% <0.00%> (-17.31%) ⬇️
...k/Features/Publications/Models/PublicationType.php 100.00% <0.00%> (ø)
...ckages/framework/src/Foundation/PageCollection.php
...k/Features/Publications/Models/PublicationType.php
...c/Framework/Features/Navigation/NavigationMenu.php
...rk/src/Framework/Features/BuildTasks/BuildTask.php
...amework/Features/Metadata/Elements/LinkElement.php
...ork/src/Framework/Features/Templates/Homepages.php
...rk/Features/Blogging/Models/LocalFeaturedImage.php
packages/framework/src/Pages/PublicationPage.php
... and 161 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

caendesilva and others added 22 commits January 6, 2023 17:53
@caendesilva
Merge branch 'publications-feature' into add-pagination-feature-to-pu…
356cb6e 
…blications
@caendesilva
Create PaginationService.php
f07c6f4
@caendesilva
Create PaginationServiceTest.php
973943f 
Update PaginationService.php
@caendesilva
Create initial data structure for pagination service
46af81d
@caendesilva
Add pagination settings getter
475996a
@caendesilva
Revert "Add pagination settings getter"
f5e95e9 
This reverts commit 475996a.
@caendesilva
Implement method to chunk the paginated page collection
b37b9c1
@caendesilva
Inline local test variables
68f70cf
@StyleCIBot
Apply fixes from StyleCI
e13da24
@caendesilva
Merge branch 'publications-feature' into add-pagination-feature-to-pu…
81718d2 
…blications
@caendesilva
Use virtual filesystem to speed up test
b2e998b
@caendesilva
Revert "Use virtual filesystem to speed up test"
fa26634 
This reverts commit b2e998b because of b4b3402
@caendesilva
Merge branch 'publications-feature' into add-pagination-feature-to-pu…
a091f0c 
…blications
@caendesilva
Split generation logic to generate method and store result in instance
fd15078
@caendesilva
Add developer note
d95446f
@caendesilva
Add additional developer note
eb110a9
@caendesilva
Update additional developer note
0f2b7aa
@caendesilva
Add $currentPage property
44d6e78
@caendesilva
Add some helper methods
7157647
@caendesilva
Add additional boolean helper methods
96be211
@caendesilva
Add todo
b701c81
@StyleCIBot
Apply fixes from StyleCI
88f2ab1
@caendesilva
Change public generator to protected void and run it in constructor
37b0801 
This simplifies the class usage, and since the class is completely useless before generation there is no reason the developer should have to call the method manually.
@caendesilva
Replace mock with actual
3d0480f
@caendesilva
Extract testing helper
e80cb14
@caendesilva
Import used functions
b517f21
@caendesilva
Rename internal property $chunks to $items
cddc353
@caendesilva
Rename method getPaginatedCollection to getPaginatedItems
c58a047
@caendesilva
Remove default value as null indicates failure
e8bb419
@caendesilva
Revert "Rename internal property $chunks to $items"
56b4d0f 
This reverts commit cddc353.
@caendesilva
Rename internal property $chunks to $paginatedItems
4ce33ad
@caendesilva
Refactor overlapping code to use helper methods
d968301
@caendesilva
Rename method hasPages to hasMultiplePages
62c7b52
@caendesilva
Reorder helper methods
7d7b540
@caendesilva
Rename traversal question methods
9900929
@caendesilva
Remove pagination prefix from internal pagination class property
958fe92 
Because redundant
@caendesilva
Extract protected helper
5970f65 
...that is useless in it self  (hence why it's not public like the lastPage method) but makes the overall code readable as it's easier to visually diff differences
@caendesilva
Extract method
e38cdab
@caendesilva
Inline withHtmlExtension parameter logic to method with usage
19888bc
@caendesilva
Extract method
e772c4f
@caendesilva caendesilva marked this pull request as ready for review January 7, 2023 21:51
@caendesilva caendesilva marked this pull request as draft January 8, 2023 10:24
@caendesilva caendesilva marked this pull request as ready for review January 8, 2023 11:47
@caendesilva caendesilva merged commit 114c07e into publications-feature Jan 8, 2023
@caendesilva caendesilva deleted the add-pagination-feature-to-publications branch January 8, 2023 11:50
This was referenced Jan 8, 2023
Closed
Merged
caendesilva added a commit that referenced this pull request Jan 13, 2023
@caendesilva
Replace internal settings state to only contain pageSize integer
83b0040 
See #814 (comment)
caendesilva added a commit that referenced this pull request Jan 13, 2023
@caendesilva
Replace $paginationSettings with $pageSize
733f563 
See #814 (comment)
caendesilva added a commit that referenced this pull request Jan 13, 2023
@caendesilva
Replace internal settings state to only contain pageSize integer
bd594f0 
See #814 (comment)
caendesilva added a commit that referenced this pull request Jan 13, 2023
@caendesilva
Replace $paginationSettings with $pageSize
a61b01e 
See #814 (comment)
@caendesilva caendesilva mentioned this pull request Feb 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caendesilva @StyleCIBot