Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor publication field definition name normalization #817

Merged
merged 15 commits into from
Jan 8, 2023
Merged

Refactor publication field definition name normalization #817

merged 15 commits into from
Jan 8, 2023

Commits on Jan 8, 2023

  1. Extract method for name normalization

    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    fe12aaa View commit details
    Browse the repository at this point in the history

  2. Replace '?:' with if

    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    8578d7e View commit details
    Browse the repository at this point in the history

  3. Document why code behaves as it does

    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    3e7cb87 View commit details
    Browse the repository at this point in the history

  4. Always return name as is when it doesn't contain spaces

    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    1b8ae79 View commit details
    Browse the repository at this point in the history

  5. Expand on code reasoning

    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    d91fcfe View commit details
    Browse the repository at this point in the history

  6. Document method as a whole

    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    dadebcf View commit details
    Browse the repository at this point in the history

  7. Transliterate to ascii

    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    7771d3c View commit details
    Browse the repository at this point in the history

  8. Use snake_case instead of kebab-case to match Laravel 

    As this is mainly used for serialization, it's best to match Laravel on this.

https://laravel.com/docs/9.x/eloquent-serialization#relationships
    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    41dab1b View commit details
    Browse the repository at this point in the history

  9. Grammar

    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    ba0d4b4 View commit details
    Browse the repository at this point in the history

  10. Expand on reasoning

    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    4cf3b81 View commit details
    Browse the repository at this point in the history

  11. Invert 'if' statement

    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    b93e897 View commit details
    Browse the repository at this point in the history

  12. Revert "Invert 'if' statement" 

    This reverts commit b93e897.
    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    de5c72f View commit details
    Browse the repository at this point in the history

  13. Apply fixes from StyleCI

    @StyleCIBot
    StyleCIBot committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    2f64a22 View commit details
    Browse the repository at this point in the history

  14. Expect case to be kept

    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    83483c5 View commit details
    Browse the repository at this point in the history

  15. Simplify and flip 'if' and inline the method

    @caendesilva
    caendesilva committed Jan 8, 2023
    Configuration menu
    Copy the full SHA
    5703683 View commit details
    Browse the repository at this point in the history