Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor publication field definition name normalization #817

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Jan 8, 2023

Takes a bit more pragmatic approach to the field name normalization

@codecov
Copy link

codecov bot commented Jan 8, 2023

Codecov Report

Merging #817 (83483c5) into publications-feature (c41fa18) will not change coverage.
The diff coverage is n/a.

❗ Current head 83483c5 differs from pull request most recent head 5703683. Consider uploading reports for the commit 5703683 to get more accurate results

@@                    Coverage Diff                     @@
##             publications-feature      #817     +/-   ##
==========================================================
  Coverage                  100.00%   100.00%             
+ Complexity                   3020      1511   -1509     
==========================================================
  Files                         338       169    -169     
  Lines                        7548      3778   -3770     
==========================================================
- Hits                         7548      3778   -3770     
Impacted Files Coverage Δ
...Publications/Models/PublicationFieldDefinition.php 100.00% <0.00%> (ø)
...Publications/Models/PublicationFieldDefinition.php
packages/framework/src/Hyde.php
...rk/Features/Blogging/Models/LocalFeaturedImage.php
...mework/Features/Session/SessionServiceProvider.php
...ications/Concerns/ParsesPublicationFieldInputs.php
...ures/BuildTasks/PostBuildTasks/GenerateRssFeed.php
...c/Console/Commands/ValidatePublicationsCommand.php
...rc/Framework/Factories/Concerns/CoreDataObject.php
...rk/src/Framework/Actions/Concerns/CreateAction.php
... and 160 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review January 8, 2023 18:22
@caendesilva caendesilva merged commit 5a61b0a into publications-feature Jan 8, 2023
@caendesilva caendesilva deleted the refactor-publication-field-definition-name-normalization- branch January 8, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants