Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor canonicable publication field internals #794

Merged
merged 31 commits into from
Dec 31, 2022
Merged

Refactor canonicable publication field internals #794

merged 31 commits into from
Dec 31, 2022

Commits on Dec 30, 2022

  1. StringField implements Stringable

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    4cdbfc4 View commit details
    Browse the repository at this point in the history

  2. Create Canonicable.php

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    b2bb3dc View commit details
    Browse the repository at this point in the history

  3. Define interface Canonicable that extends Stringable

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    372e1bc View commit details
    Browse the repository at this point in the history

  4. Class StringField implements Canonicable instead of Stringable directly

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    7586a94 View commit details
    Browse the repository at this point in the history

  5. Create CanonicableTrait.php

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    7c69edb View commit details
    Browse the repository at this point in the history

  6. Use CanonicableTrait

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    be66418 View commit details
    Browse the repository at this point in the history

  7. Implement the trait methods

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    a119b30 View commit details
    Browse the repository at this point in the history

  8. Limit canonicable string length to 64 characters

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    ee16fcd View commit details
    Browse the repository at this point in the history

  9. Throw exception if the canonical value is empty

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    a9642da View commit details
    Browse the repository at this point in the history

  10. Deprecate canonicable method

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    317a8c7 View commit details
    Browse the repository at this point in the history

  11. Update all canonicable types to implement the interface

    @caendesilva
    caendesilva committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    c1ca25e View commit details
    Browse the repository at this point in the history

  12. Apply fixes from StyleCI

    @StyleCIBot
    StyleCIBot committed Dec 30, 2022
    Configuration menu
    Copy the full SHA
    021c691 View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2022

  1. Move trait into Concerns sub-namespace

    @caendesilva
    caendesilva committed Dec 31, 2022
    Configuration menu
    Copy the full SHA
    6a2d4e4 View commit details
    Browse the repository at this point in the history

  2. Apply fixes from StyleCI

    @StyleCIBot
    StyleCIBot committed Dec 31, 2022
    Configuration menu
    Copy the full SHA
    6c8a52b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'publications-feature' into refactor-publication-field-c… 

    …lasses
    @caendesilva
    caendesilva committed Dec 31, 2022
    Configuration menu
    Copy the full SHA
    40eb089 View commit details
    Browse the repository at this point in the history

  4. Create CanonicableTraitTest.php

    @caendesilva
    caendesilva committed Dec 31, 2022
    Configuration menu
    Copy the full SHA
    cc445cc View commit details
    Browse the repository at this point in the history

  5. Generate method stubs

    @caendesilva
    caendesilva committed Dec 31, 2022
    Configuration menu
    Copy the full SHA
    db83e90 View commit details
    Browse the repository at this point in the history

  6. Create a test class to test the trait

    @caendesilva
    caendesilva committed Dec 31, 2022
    Configuration menu
    Copy the full SHA
    5d37d89 View commit details
    Browse the repository at this point in the history

  7. Reorder test methods to match subject

    @caendesilva
    caendesilva committed Dec 31, 2022
    Configuration menu
    Copy the full SHA
    127861d View commit details
    Browse the repository at this point in the history

  8. Implement the base test

    @caendesilva
    caendesilva committed Dec 31, 2022
    Configuration menu
    Copy the full SHA
    e38a449 View commit details
    Browse the repository at this point in the history

  9. Add additional tests

    @caendesilva
    caendesilva committed Dec 31, 2022
    Configuration menu
    Copy the full SHA
    8591abb View commit details
    Browse the repository at this point in the history

  10. Fix test not calling the subject method

    @caendesilva
    caendesilva committed Dec 31, 2022
    Configuration menu
    Copy the full SHA
    058be0a View commit details
    Browse the repository at this point in the history

  11. Replace qualifier with an import

    @caendesilva
    caendesilva committed Dec 31, 2022
    Configuration menu
    Copy the full SHA
    2938d58 View commit details
    Browse the repository at this point in the history

  12. Remove test for deprecated method

    @caendesilva
    caendesilva committed Dec 31, 2022
    Configuration menu
    Copy the full SHA
    6ce2042 View commit details
    Browse the repository at this point in the history

  13. Revert "Inline fieldClass helper method" 

    This reverts commit 634ab32.
    @caendesilva
    caendesilva committed Dec 31, 2022
    Configuration menu
    Copy the full SHA
    467199c View commit details
    Browse the repository at this point in the history

  14. Merge fieldClass helper method changes

    @caendesilva
    caendesilva committed Dec 31, 2022
    Configuration menu
    Copy the full SHA
    97ad6af View commit details
    Browse the repository at this point in the history

  15. Check instanceof instead of in_array

    @caendesilva
    caendesilva committed Dec 31, 2022
    Configuration menu
    Copy the full SHA
    72e317f View commit details
    Browse the repository at this point in the history

  16. Use is_a instead of instanceof

    @caendesilva
    caendesilva committed Dec 31, 2022
    Configuration menu
    Copy the full SHA
    72a9ce3 View commit details
    Browse the repository at this point in the history

  17. Remove unused deprecated canonicable method

    @caendesilva
    caendesilva committed Dec 31, 2022
    Configuration menu
    Copy the full SHA
    c12e327 View commit details
    Browse the repository at this point in the history

  18. Inline local variable

    @caendesilva
    caendesilva committed Dec 31, 2022
    Configuration menu
    Copy the full SHA
    603c858 View commit details
    Browse the repository at this point in the history

  19. Apply fixes from StyleCI

    @StyleCIBot
    StyleCIBot committed Dec 31, 2022
    Configuration menu
    Copy the full SHA
    e0ba5f0 View commit details
    Browse the repository at this point in the history