Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor canonicable publication field internals #794

Merged
merged 31 commits into from
Dec 31, 2022

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Dec 30, 2022

Refactors to add an interface and trait for publication field values that can be canonical

@codecov
Copy link

codecov bot commented Dec 30, 2022

Codecov Report

Merging #794 (e0ba5f0) into publications-feature (f9020ab) will decrease coverage by 0.19%.
The diff coverage is n/a.

@@                    Coverage Diff                     @@
##             publications-feature     #794      +/-   ##
==========================================================
- Coverage                  100.00%   99.80%   -0.20%     
+ Complexity                   2848     1427    -1421     
==========================================================
  Files                         348      175     -173     
  Lines                        7162     3585    -3577     
==========================================================
- Hits                         7162     3578    -3584     
- Misses                          0        7       +7     
Impacted Files Coverage Δ
...rk/Features/Publications/PublicationFieldTypes.php 86.36% <0.00%> (-13.64%) ⬇️
...rk/src/Console/Commands/MakePublicationCommand.php 100.00% <0.00%> (ø)
...ations/Models/PublicationFieldValues/TextField.php 100.00% <0.00%> (ø)
...ions/Models/PublicationFieldValues/StringField.php 100.00% <0.00%> (ø)
...ons/Models/PublicationFieldValues/IntegerField.php 100.00% <0.00%> (ø)
...ns/Models/PublicationFieldValues/DatetimeField.php 100.00% <0.00%> (ø)
...rk/src/Console/Commands/MakePublicationCommand.php
...rc/Console/Commands/MakePublicationTypeCommand.php
...ns/Models/PublicationFieldValues/DatetimeField.php
...ons/Models/PublicationFieldValues/IntegerField.php
... and 171 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review December 31, 2022 11:18
@caendesilva caendesilva merged commit 4e0a54f into publications-feature Dec 31, 2022
@caendesilva caendesilva deleted the refactor-publication-field-classes branch December 31, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants