Internal: Handle skipped tests #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
internal
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1755 +/- ##
============================================
- Coverage 99.95% 99.95% -0.01%
+ Complexity 1750 1749 -1
============================================
Files 181 181
Lines 4675 4673 -2
============================================
- Hits 4673 4671 -2
Misses 2 2 ☔ View full report in Codecov by Sentry. |
This was useful way back when when we used a manual versioning system and this could catch cases where I messed up, but now that versioning is automated this is not needed.
caendesilva
force-pushed
the
handle-skipped-tests
branch
from
bd83615
to
fd1e7e6
Compare
Want to know what this is about, and if it actually gets triggered
|
Alright, nothing more to handle here. Good for merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes over all the skipped tests to see what we can do about them (remove, fix, rework, etc)