Merge pull request #1755 from hydephp/handle-skipped-tests

Internal: Handle skipped tests
hydephp · Jun 29, 2024 · 7170185 · 7170185
2 parents 4ccc8d2 + 221ac91
commit 7170185
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 36 deletions.
diff --git a/packages/framework/tests/Feature/Commands/ServeCommandTest.php b/packages/framework/tests/Feature/Commands/ServeCommandTest.php
@@ -9,7 +9,6 @@
 use Hyde\Testing\TestCase;
 use Illuminate\Support\Facades\Process;
 use TypeError;
-use Hyde\RealtimeCompiler\ConsoleOutput;
 
 /**
  * @covers \Hyde\Console\Commands\ServeCommand
@@ -166,10 +165,6 @@ public function testHydeServeCommandPassesThroughProcessOutput()
 
     public function testWithFancyOutput()
     {
-        if (! class_exists(ConsoleOutput::class)) {
-            $this->markTestSkipped('ConsoleOutput class not found.');
-        }
-
         Process::fake(['php -S localhost:8080 {$this->binaryPath()}' => 'foo']);
 
         $this->artisan('serve')

diff --git a/packages/framework/tests/Feature/HydeKernelTest.php b/packages/framework/tests/Feature/HydeKernelTest.php
@@ -4,9 +4,7 @@
 
 namespace Hyde\Framework\Testing\Feature;
 
-use Throwable;
 use Hyde\Enums\Feature;
-use Composer\InstalledVersions;
 use Hyde\Facades\Features;
 use Hyde\Foundation\Facades\Pages;
 use Hyde\Foundation\Facades\Routes;
@@ -306,34 +304,6 @@ public function testVersionConstantIsAValidSemverString()
         );
     }
 
-    public function testVersionConstantIsUpToDateWithComposer()
-    {
-        $version = InstalledVersions::getPrettyVersion('hyde/framework');
-
-        if (str_starts_with($version, 'dev-')) {
-            $this->markTestSkipped('Installed version is for development');
-        }
-
-        $this->assertSame(HydeKernel::VERSION, $version);
-    }
-
-    public function testVersionConstantIsUpToDateWithGit()
-    {
-        try {
-            $version = trim(shell_exec('git describe --abbrev=0 --tags'));
-        } catch (Throwable) {
-            // Gracefully skip the test if the version cannot be fetched
-            $this->markTestSkipped('Could not get version from Git');
-        }
-
-        if ('v'.HydeKernel::VERSION === $version) {
-            $this->assertSame('v'.HydeKernel::VERSION, $version);
-        } else {
-            // Gracefully skip the test if the version is not up-to-date
-            $this->markTestSkipped('Version constant does not match Git version!');
-        }
-    }
-
     public function testVersionMethodReturnsVersionConstant()
     {
         $this->assertSame(HydeKernel::VERSION, Hyde::version());

diff --git a/packages/framework/tests/Unit/HydeConfigFilesAreMatchingTest.php b/packages/framework/tests/Unit/HydeConfigFilesAreMatchingTest.php
@@ -18,7 +18,7 @@ protected function setUp(): void
     {
         parent::setUp();
 
-        if (file_exists(Hyde::path('README.md')) && ! str_contains(file_get_contents(Hyde::path('README.md')), 'HydePHP - Source Monorepo')) {
+        if (file_exists(Hyde::path('README.md')) && ! str_contains(file_get_contents(Hyde::path('README.md')), 'HydePHP - Source Code Monorepo')) {
             $this->markTestSkipped('Test skipped when not running in the monorepo.');
         }
     }