[2.x] Clean up navigation view markup #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks more consistent with the dropdown include just above, and we can use attributes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## improved-navigation-internals #1606 +/- ##
===================================================================
- Coverage 99.95% 99.87% -0.09%
Complexity 1778 1778
===================================================================
Files 184 184
Lines 4809 4809
===================================================================
- Hits 4807 4803 -4
- Misses 2 6 +4 ☔ View full report in Codecov by Sentry. |
Adds a styling hook, and makes it more readable and testable
Normalizes with 894a865
caendesilva
force-pushed
the
clean-up-navigation-view-markup
branch
from
3dba69a
to
c61eef9
Compare
Create attribute bag in test setup Update test to expect cleaner HTML output
caendesilva
force-pushed
the
clean-up-navigation-view-markup
branch
from
4cdda0e
to
759c63a
Compare
caendesilva
force-pushed
the
clean-up-navigation-view-markup
branch
from
ba30faa
to
d5f33f6
Compare
caendesilva
force-pushed
the
clean-up-navigation-view-markup
branch
from
0ebe5a2
to
7b1868e
Compare
caendesilva
force-pushed
the
clean-up-navigation-view-markup
branch
from
c8a9be5
to
e15daca
Compare
Adds an option to use this with just the full attribute string
caendesilva
force-pushed
the
clean-up-navigation-view-markup
branch
from
5677966
to
2eeed5f
Compare
Granular logic belongs in child tests
caendesilva
force-pushed
the
improved-navigation-internals
branch
from
fc3a63c
to
fb13736
Compare
caendesilva
force-pushed
the
clean-up-navigation-view-markup
branch
from
80727cc
to
f6257f9
Compare
caendesilva
force-pushed
the
clean-up-navigation-view-markup
branch
from
a821627
to
b84cdf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.