Refactor component to use attribute merging

hydephp · Mar 13, 2024 · 3dba69a · 3dba69a
1 parent 6ba9eaf
commit 3dba69a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/packages/framework/resources/views/components/navigation/navigation-link.blade.php b/packages/framework/resources/views/components/navigation/navigation-link.blade.php
@@ -1,4 +1,6 @@
-<a href="{{ $item }}" {!! $item->isActive() ? 'aria-current="page"' : '' !!} @class([
+<a href="{{ $item }}" {{ ($attributes->except('item')->class([
     'navigation-link block my-2 md:my-0 md:inline-block py-1 text-gray-700 hover:text-gray-900 dark:text-gray-100',
     'navigation-link-active border-l-4 border-indigo-500 md:border-none font-medium -ml-6 pl-5 md:ml-0 md:pl-0 bg-gray-100 dark:bg-gray-800 md:bg-transparent dark:md:bg-transparent' => $item->isActive()
-])>{{ $item->getLabel() }}</a>
+])->merge([
+    'aria-current' => ($item->isActive() ? 'page' : false),
+])) }}>{{ $item->getLabel() }}</a>
diff --git a/packages/framework/tests/Unit/Views/NavigationMenuViewTest.php b/packages/framework/tests/Unit/Views/NavigationMenuViewTest.php
@@ -73,7 +73,7 @@ public function testNavigationMenuWithRootPages()
         $contents = $foo->compile();
 
         $this->assertStringContainsString('<a href="foo.html" aria-current="page" class="', $contents);
-        $this->assertStringContainsString('<a href="bar.html"  class="', $contents);
+        $this->assertStringContainsString('<a href="bar.html" class="', $contents);
     }
 
     public function testNavigationMenuWithDropdownPages()