Publications refactors #1370
Merged
Publications refactors #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes the PublicationPage::$type property readonly as it can't be persisted like that There is no logic to change the type through the object, and I don't think there should be as it would add a considerable amount of complexity compared to the user just moving the file. Making it readonly makes it clear that it cannot be changed as changing the property would do nothing.
Codecov Report
@@ Coverage Diff @@
## publications-feature #1370 +/- ##
=========================================================
Coverage 99.97% 99.97%
+ Complexity 3394 1694 -1700
=========================================================
Files 360 180 -180
Lines 9170 4586 -4584
=========================================================
- Hits 9168 4585 -4583
+ Misses 2 1 -1 see 183 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
caendesilva
force-pushed
the
publications-refactors
branch
from
cd77321
to
59bceee
Compare
This just makes it all clearer. If/when we add more meta fields, that's something we can revisit then.
caendesilva
force-pushed
the
publications-refactors
branch
from
b5e91f6
to
7f4718c
Compare
caendesilva
force-pushed
the
publications-refactors
branch
from
69b73f9
to
eb02163
Compare
caendesilva
force-pushed
the
publications-refactors
branch
from
35fc0d9
to
b626aad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.