Inline helper method parameter value

hydephp · Apr 25, 2023 · eb02163 · eb02163
1 parent b2d97d2
commit eb02163
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/packages/publications/src/Commands/MakePublicationCommand.php b/packages/publications/src/Commands/MakePublicationCommand.php
@@ -151,7 +151,7 @@ protected function captureMediaFieldInput(PublicationFieldDefinition $field): ?P
 
         $mediaFiles = Publications::getMediaForType($this->publicationType);
         if ($mediaFiles->isEmpty()) {
-            return $this->handleEmptyMediaFilesCollection($field, 'media file',
+            return $this->handleEmptyMediaFilesCollection($field,
                 // TODO Ask to pick from root media directory?
                 sprintf('No media files found in directory %s/%s/', Hyde::getMediaDirectory(),
                     $this->publicationType->getIdentifier()
@@ -163,7 +163,7 @@ protected function captureMediaFieldInput(PublicationFieldDefinition $field): ?P
     }
 
     /** @return null */
-    protected function handleEmptyMediaFilesCollection(PublicationFieldDefinition $field, string $type, string $message)
+    protected function handleEmptyMediaFilesCollection(PublicationFieldDefinition $field, string $message)
     {
         if (in_array('required', $field->rules)) {
             throw new InvalidArgumentException("Unable to create publication: $message");
@@ -174,7 +174,7 @@ protected function handleEmptyMediaFilesCollection(PublicationFieldDefinition $f
         if ($this->confirm('Would you like to skip this field?', true)) {
             return null;
         } else {
-            throw new InvalidArgumentException("Unable to locate any {$type}s for this publication type");
+            throw new InvalidArgumentException('Unable to locate any media files for this publication type');
         }
     }