Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use include_cache on head/links.html #266

Merged
merged 1 commit into from
Mar 28, 2021
Merged

Conversation

rmgrimm
Copy link

@rmgrimm rmgrimm commented Mar 9, 2021

This resolves an issue where the base index page would include the wrong URL for a would-be self-referencing hreflang link.

For example, today https://hydejack.com has a would-be self link as follows:

<link rel="alternate" href="https://hydejack.com/blog/hyde/2012-02-06-whats-jekyll/" hreflang="en">

After changing to include from include_cache, it would be correct:

<link rel="alternate" href="https://hydejack.com/" hreflang="en">

This resolves an issue where the base index page would include the wrong URL for a would-be self-referencing hreflang link.
@qwtel qwtel merged commit 4398e7a into hydecorp:master Mar 28, 2021
qwtel added a commit that referenced this pull request Mar 28, 2021
Don't use include_cache on head/links.html

(cherry picked from commit 4398e7a)
@qwtel
Copy link
Member

qwtel commented Mar 28, 2021

Again, thanks for catching this.

@rmgrimm rmgrimm deleted the patch-1 branch March 28, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants