Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xxxTrainer] multi-tags support for tagging #1133

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Conversation

younesbelkada
Copy link
Contributor

@younesbelkada younesbelkada commented Dec 22, 2023

What does this PR do?

Instead of pushing a single tag, this PR changes the current behaviour of xxxTrainer tagging to push multiple tags (e.g. trl & sft) instead of a single tag

cc @lvwerra @osanseviero

example here: https://huggingface.co/ybelkada/test-multi-tag

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@younesbelkada younesbelkada merged commit 0c4edb7 into main Dec 22, 2023
9 checks passed
@younesbelkada younesbelkada deleted the add-correct-tags-2 branch December 22, 2023 13:52
Copy link
Member

@osanseviero osanseviero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

lapp0 pushed a commit to lapp0/trl that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants