[testing] skip decorators: docs, tests, bugs #7334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Codecov Report
@@ Coverage Diff @@
## master #7334 +/- ##
==========================================
- Coverage 80.48% 76.73% -3.76%
==========================================
Files 181 181
Lines 34827 34827
==========================================
- Hits 28032 26724 -1308
- Misses 6795 8103 +1308
Continue to review full report at Codecov.
|
stas00
changed the title
stas00
changed the title
LysandreJik
approved these changes
Sep 23, 2020
| if torch_device != "cuda": | ||
| return unittest.skip("test requires CUDA") | ||
| return unittest.skip("test requires CUDA")(test_case) |
thevasudevgupta
pushed a commit
to thevasudevgupta/transformers
that referenced
this pull request
Sep 29, 2020
* skip decorators: docs, tests, bugs * another important note * style * bloody style * add @pytest.mark.parametrize * add note * no idea what it wants :(
fabiocapsouza
pushed a commit
to fabiocapsouza/transformers
that referenced
this pull request
Nov 15, 2020
* skip decorators: docs, tests, bugs * another important note * style * bloody style * add @pytest.mark.parametrize * add note * no idea what it wants :(
fabiocapsouza
added a commit
to fabiocapsouza/transformers
that referenced
this pull request
Nov 15, 2020
This reverts commit 75939a5.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
require_torch_and_cudatesting.rstnotesOK, so other than a small bug in
require_torch_and_cudaour skip decorators can be used in any order.The only problem I found so far is when they are used together with
@parameterized, which has to come first and skip decorators last. It rewrites test names, to create a unique test name for each parameter group. and then it runs them - it has no idea it may have any skip decorators before it (The decorators get all stacked, and one below has no idea what the one above does).If you find other unusual decorators, please let me know and I will investigate.
Partially fixes #7326
@LysandreJik, @sgugger