Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template updates #6914

Merged
merged 1 commit into from
Sep 3, 2020
Merged

Template updates #6914

merged 1 commit into from
Sep 3, 2020

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Sep 2, 2020

When adding the Funnel Transformer, I noticed a few things wrong in the template. This PR fixes those.

  • using transformers.testing_utils instead of .utils
  • remove xxx from names in tests (as @patrickvonplaten has done recently on Bert)
  • add multiple choice model test
  • fix label names in masked lm model
  • remove the mention to add to pipelines.py in the checklist since there is nothing to do there

@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #6914 into master will increase coverage by 1.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6914      +/-   ##
==========================================
+ Coverage   77.81%   79.03%   +1.21%     
==========================================
  Files         157      157              
  Lines       28853    28853              
==========================================
+ Hits        22452    22804     +352     
+ Misses       6401     6049     -352     
Impacted Files Coverage Δ
src/transformers/modeling_tf_mobilebert.py 24.55% <0.00%> (-72.36%) ⬇️
src/transformers/tokenization_pegasus.py 30.15% <0.00%> (-65.08%) ⬇️
src/transformers/modeling_roberta.py 77.73% <0.00%> (-19.35%) ⬇️
src/transformers/data/data_collator.py 92.30% <0.00%> (-0.41%) ⬇️
src/transformers/modeling_utils.py 88.05% <0.00%> (+0.18%) ⬆️
src/transformers/tokenization_utils.py 89.84% <0.00%> (+0.39%) ⬆️
src/transformers/generation_utils.py 97.21% <0.00%> (+0.83%) ⬆️
src/transformers/configuration_utils.py 96.64% <0.00%> (+1.34%) ⬆️
src/transformers/modeling_distilbert.py 97.84% <0.00%> (+1.61%) ⬆️
src/transformers/modelcard.py 85.18% <0.00%> (+2.46%) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ebb52a...408286d. Read the comment docs.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @sgugger

@LysandreJik LysandreJik merged commit 722b580 into master Sep 3, 2020
@LysandreJik LysandreJik deleted the fix_template branch September 3, 2020 08:15
Zigur pushed a commit to Zigur/transformers that referenced this pull request Oct 26, 2020
fabiocapsouza pushed a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
fabiocapsouza added a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants