Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hot fix self.position_embeddings->self.position_embedding #33958

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

ArthurZucker
Copy link
Collaborator

What does this PR do?

Fixes #33929

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ArthurZucker ArthurZucker merged commit 46579c0 into main Oct 4, 2024
17 checks passed
@ArthurZucker ArthurZucker deleted the hot-fix-siglip branch October 4, 2024 19:35
@mranzinger
Copy link

I think this is still broken. self.position_embedding is of type nn.Embedding, which means it doesn't have a .shape variable.

I think you want to bring back

position_embeddings = self.position_embedding.weight.unsqueeze(0)

@ArthurZucker
Copy link
Collaborator Author

🫠 yep

@ArthurZucker
Copy link
Collaborator Author

Opening a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PaliGemma (and probably SigLIP) inference broken in latest transformers version
3 participants