fix: Fixed the arguments in create_repo() function call
#31947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyeroberts
approved these changes
Jul 15, 2024
…to fix_create_repo_args
zucchini-nlp
pushed a commit
to zucchini-nlp/transformers
that referenced
this pull request
Jul 16, 2024
…e#31947) * Fixed the arguments in create_repo() function call. * Formatted the code properly using ruff. * Formatted the code more clearly.
amyeroberts
pushed a commit
to amyeroberts/transformers
that referenced
this pull request
Jul 19, 2024
…e#31947) * Fixed the arguments in create_repo() function call. * Formatted the code properly using ruff. * Formatted the code more clearly.
MHRDYN7
pushed a commit
to MHRDYN7/transformers
that referenced
this pull request
Jul 23, 2024
…e#31947) * Fixed the arguments in create_repo() function call. * Formatted the code properly using ruff. * Formatted the code more clearly.
zucchini-nlp
pushed a commit
to zucchini-nlp/transformers
that referenced
this pull request
Jul 24, 2024
…e#31947) * Fixed the arguments in create_repo() function call. * Formatted the code properly using ruff. * Formatted the code more clearly.
itazap
pushed a commit
that referenced
this pull request
Jul 25, 2024
* Fixed the arguments in create_repo() function call. * Formatted the code properly using ruff. * Formatted the code more clearly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The argument names passed in the
create_repo()function call here are currently wrong, we can see this from the actual definition of create_repo() here, there are no argumentsname&organization.transformers/src/transformers/commands/user.py
Line 188 in 7f79a97
Found it similar to this class.
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@amyeroberts @ArthurZucker