Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GenerationMixin.generate compatibility with pytorch profiler #31935

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

fxmarty
Copy link
Contributor

@fxmarty fxmarty commented Jul 12, 2024

As per title and discussed internally, more details at pytorch/pytorch#130622

@fxmarty fxmarty requested a review from gante July 12, 2024 16:27
Copy link
Member

@gante gante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gante gante requested a review from amyeroberts July 12, 2024 16:32
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@gante gante merged commit 8480fda into huggingface:main Jul 14, 2024
21 checks passed
amyeroberts pushed a commit to amyeroberts/transformers that referenced this pull request Jul 19, 2024
MHRDYN7 pushed a commit to MHRDYN7/transformers that referenced this pull request Jul 23, 2024
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request Jul 24, 2024
itazap pushed a commit that referenced this pull request Jul 25, 2024
…31935)

use torch.compiler.is_compiling() when possible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants