[ConvertSlow] make sure the order is preserved for addedtokens
#31902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
itazap
reviewed
Jul 11, 2024
| ] | ||
| } | ||
|
|
||
| tokenizer.add_tokens([k for _, k in sorted(all_added_tokens.items(), key=lambda x: x[0])]) |
There was a problem hiding this comment.
Thanks for the fast fix! Is the sorting here necessary or is it already sorted from enumerate?
There was a problem hiding this comment.
not sure that the dict is an ordered dict by default for all python version! just for safety!
tests are failing because this is the sentencepiece.model that was uploaded
|
4 tasks
amyeroberts
pushed a commit
to amyeroberts/transformers
that referenced
this pull request
Jul 19, 2024
…gingface#31902) * preserve the order * oups * oups * nit * trick * fix issues
MHRDYN7
pushed a commit
to MHRDYN7/transformers
that referenced
this pull request
Jul 23, 2024
…gingface#31902) * preserve the order * oups * oups * nit * trick * fix issues
zucchini-nlp
pushed a commit
to zucchini-nlp/transformers
that referenced
this pull request
Jul 24, 2024
…gingface#31902) * preserve the order * oups * oups * nit * trick * fix issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
@zucchini-nlp caught a nice bug: the order of the user defined tokens and control tokens was not preserved