-
Notifications
You must be signed in to change notification settings - Fork 26.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ConvertSlow
] make sure the order is preserved for addedtokens
#31902
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok!
] | ||
} | ||
|
||
tokenizer.add_tokens([k for _, k in sorted(all_added_tokens.items(), key=lambda x: x[0])]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fast fix! Is the sorting here necessary or is it already sorted from enumerate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure that the dict is an ordered dict by default for all python version! just for safety!
…gingface#31902) * preserve the order * oups * oups * nit * trick * fix issues
…gingface#31902) * preserve the order * oups * oups * nit * trick * fix issues
…gingface#31902) * preserve the order * oups * oups * nit * trick * fix issues
What does this PR do?
@zucchini-nlp caught a nice bug: the order of the user defined tokens and control tokens was not preserved