Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing methods for Fuyu #31880

Merged
merged 6 commits into from
Jul 11, 2024
Merged

Fix missing methods for Fuyu #31880

merged 6 commits into from
Jul 11, 2024

Conversation

Isotr0py
Copy link
Contributor

What does this PR do?

This PR add missing methods in modeling_fuyu.py like get_output_embeddings etc.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@amyeroberts
Copy link
Collaborator

cc @molbap

molbap
molbap approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@molbap molbap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding! I'm not sure weights are tied for fuyu base model but good to have for derived forms

amyeroberts
amyeroberts approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding!

@amyeroberts amyeroberts merged commit 48c2070 into huggingface:main Jul 11, 2024
18 checks passed
@Isotr0py Isotr0py deleted the fuyu branch July 12, 2024 03:14
amyeroberts pushed a commit to amyeroberts/transformers that referenced this pull request Jul 19, 2024
@Isotr0py @amyeroberts
Fix missing methods for Fuyu (huggingface#31880)
04528c3 
* add missing methods for FuyuForCausalLM

* fix a typo

* format code

* add missing tie_weights

* format code
MHRDYN7 pushed a commit to MHRDYN7/transformers that referenced this pull request Jul 23, 2024
@Isotr0py @MHRDYN7
Fix missing methods for Fuyu (huggingface#31880)
fe1b3e4 
* add missing methods for FuyuForCausalLM

* fix a typo

* format code

* add missing tie_weights

* format code
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request Jul 24, 2024
@Isotr0py @zucchini-nlp
Fix missing methods for Fuyu (huggingface#31880)
e30a505 
* add missing methods for FuyuForCausalLM

* fix a typo

* format code

* add missing tie_weights

* format code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyeroberts amyeroberts amyeroberts approved these changes

@molbap molbap molbap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Isotr0py @amyeroberts @molbap