Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file type checks in data splits for contrastive training example script #31720

Merged

Conversation

npyoung
Copy link
Contributor

@npyoung npyoung commented Jul 1, 2024

What does this PR do?

After checking if the validation file is a json or csv, existing code checks again to make sure it is only a json. This PR checks if the test file is a json or csv, as with validation and training, and does not force the validation file to be json.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@amyeroberts
Copy link
Collaborator

@npyoung Could you rebase on main? This will include upstream changes which should resolve the failing errors on the CI

@npyoung npyoung force-pushed the contrastive-example-validation-formats branch from 43ed1f6 to 942d2bd Compare July 6, 2024 21:29
@amyeroberts amyeroberts merged commit a0a3e2f into huggingface:main Jul 10, 2024
7 checks passed
amyeroberts pushed a commit to amyeroberts/transformers that referenced this pull request Jul 19, 2024
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants