Siglip: add _no_split_module
#31566
Merged
Siglip: add _no_split_module
#31566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
amyeroberts
reviewed
Jun 24, 2024
Comment on lines
1021
to
1027
| _no_split_modules = [ | ||
| "SiglipTextEmbeddings", | ||
| "SiglipEncoderLayer", | ||
| "SiglipVisionEmbeddings", | ||
| "SiglipEncoderLayer", | ||
| "SiglipMultiheadAttentionPoolingHead", | ||
| ] |
There was a problem hiding this comment.
What happens if we have modules defined in _no_split_modules which aren't in the model? It probably makes more sense to move this into the PretrainedModel definition than repeat e.g. "SiglipVisionEmbeddings" for all models which use the vision components
There was a problem hiding this comment.
Great idea! Didn't think that extra split_modules will not affect anything. Moved to SiglipPretrained model and ran tests. Had to skip offloading, same way it's skipped in SigLipVision
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #31400. Adds a '_no_split_module' in SigLipModel by combining those specified in Text and Vision components.
Otherwise, when we call SiglipModel with
device_mapan error will be thrown because Text/Vision components are not children of SiglipModel and we need to add_no_split_module