Use self.config_tester.run_common_tests() #31431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyeroberts
changed the title
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
amyeroberts
changed the title
amyeroberts
force-pushed
the
test-vision-config-properties-properly
branch
from
7059510
to
c16a8b0
Compare
ydshieh
approved these changes
Jun 19, 2024
itazap
pushed a commit
that referenced
this pull request
Jun 20, 2024
* First testing updating config tests * Use run_common_tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove overrides of
test_configto useself.config_test.run_common_tests(). This makes sure all of the config tests intest_configuration_common.pyare being runIn some cases,
common_propertiesis set when creating the config tester. This is a bit hacky, but ascommon_propertiesisn't that well defined in the original test I think this is OK until we split into different testing modalities.c.f. #31359 (review)