Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change potential inputs_embeds padding logger.warning to logger.warning_once #31411

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

naimenz
Copy link
Contributor

@naimenz naimenz commented Jun 14, 2024

What does this PR do?

This PR changes the warning for potential padding in embeddings from logger.warning to logger.warning_once

Fixes #30871

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@amyeroberts

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@amyeroberts
Copy link
Collaborator

@naimenz Could you rebase to include the recent changes on main? The datasets library had a recent release which is causing the failures on the CI runs for this PR. We pushed a commit #31417 which resolves this, but will need to be included on this branch to set up the right CI env

@naimenz
Copy link
Contributor Author

naimenz commented Jun 14, 2024

Oh sure, rebased now! Thanks @amyeroberts

@amyeroberts amyeroberts merged commit c212ac9 into huggingface:main Jun 14, 2024
19 checks passed
itazap pushed a commit that referenced this pull request Jun 17, 2024
…warning_once` (#31411)

change embeddings padding warning to warning_once
itazap pushed a commit that referenced this pull request Jun 17, 2024
…warning_once` (#31411)

change embeddings padding warning to warning_once
itazap pushed a commit that referenced this pull request Jun 17, 2024
…warning_once` (#31411)

change embeddings padding warning to warning_once
itazap pushed a commit that referenced this pull request Jun 18, 2024
…warning_once` (#31411)

change embeddings padding warning to warning_once
itazap pushed a commit that referenced this pull request Jun 20, 2024
…warning_once` (#31411)

change embeddings padding warning to warning_once
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsuppressable warning: "<model> will not detect padding tokens in inputs_embeds"
2 participants