-
Notifications
You must be signed in to change notification settings - Fork 26.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix idefics cache #31377
Merged
Merged
Fix idefics cache #31377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This was referenced Jun 12, 2024
amyeroberts
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing!
zucchini-nlp
added a commit
to zucchini-nlp/transformers
that referenced
this pull request
Jun 14, 2024
* fix idefics cache * fix tests
itazap
pushed a commit
that referenced
this pull request
Jun 17, 2024
* fix idefics cache * fix tests
itazap
pushed a commit
that referenced
this pull request
Jun 17, 2024
* fix idefics cache * fix tests
itazap
pushed a commit
that referenced
this pull request
Jun 17, 2024
* fix idefics cache * fix tests
itazap
pushed a commit
that referenced
this pull request
Jun 18, 2024
* fix idefics cache * fix tests
itazap
pushed a commit
that referenced
this pull request
Jun 20, 2024
* fix idefics cache * fix tests
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #31373 and fixes #31380. We have to update past kv length in all cases, not only when
return_legacy_cache=True
. Also removedpast_length = past_key_values.seen_tokens
as it's deprecated and shows same length asget_seq_length