Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Clip QKV for MPT #31307

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

akakakakakaa
Copy link
Contributor

@akakakakakaa akakakakakaa commented Jun 7, 2024

What does this PR do?

  • Support Clip QKV for MPT

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@ArthurZucker and @younesbelkada

Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this - @ArthurZucker indeed clip_qkv seems to be always there in MPTConfig: https://huggingface.co/mosaicml/mpt-7b/blob/main/config.json#L12 /

clip_qkv (`float`, *optional*):
but we never used it

@akakakakakaa
Copy link
Contributor Author

@younesbelkada
Is there any issue with merging this PR? Looking at the failed tests, it doesn't seem to be a problem with the PR code.

@younesbelkada
Copy link
Contributor

Yes this looks good for me, just waiting for final core maintainer review
cc @amyeroberts @ArthurZucker

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this support!

@amyeroberts amyeroberts merged commit cfb22e0 into huggingface:main Jun 14, 2024
20 checks passed
itazap pushed a commit that referenced this pull request Jun 17, 2024
itazap pushed a commit that referenced this pull request Jun 17, 2024
itazap pushed a commit that referenced this pull request Jun 17, 2024
itazap pushed a commit that referenced this pull request Jun 18, 2024
itazap pushed a commit that referenced this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants