Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Qwen2 GGUF loading support #31175

Merged
merged 9 commits into from
Jun 3, 2024
Merged

Add Qwen2 GGUF loading support #31175

merged 9 commits into from
Jun 3, 2024

Conversation

Isotr0py
Copy link
Contributor

@Isotr0py Isotr0py commented Jun 1, 2024

What does this PR do?

  • Add Qwen2 GGUF loading support
  • Use model_type for gguf tokenizer converter selection instead of tokenizer_type

According to convert-hf-to-gguf.py, most of models may register tokenizer as gpt2 tokenizer. Use model_type to select corresponding tokenizer instead of tokenizer_type.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this great contribution ! Can you confirm the other slow tests pass ? 🙏 I left few minor comments, what do you think?

src/transformers/integrations/ggml.py Show resolved Hide resolved
src/transformers/integrations/ggml.py Outdated Show resolved Hide resolved
src/transformers/integrations/ggml.py Outdated Show resolved Hide resolved
src/transformers/integrations/ggml.py Show resolved Hide resolved
src/transformers/tokenization_utils_fast.py Show resolved Hide resolved
Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work ! Thanks for adding Qwen2 support for GGUF files ! Can you run the styling checks? make fixup after that this PR is ready IMO

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding!

src/transformers/convert_slow_tokenizer.py Outdated Show resolved Hide resolved
src/transformers/integrations/ggml.py Show resolved Hide resolved
@amyeroberts amyeroberts merged commit e462843 into huggingface:main Jun 3, 2024
20 checks passed
@Isotr0py Isotr0py deleted the gguf branch June 3, 2024 13:58
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request Jun 11, 2024
* add qwen2 gguf support

* Update docs

* fix qwen2 tokenizer

* add qwen2 gguf test

* fix typo in qwen2 gguf test

* format code

* Remove mistral, clarify the error message

* format code

* add typing and update docstring
@SunMarc SunMarc mentioned this pull request Jul 8, 2024
2 tasks
@a8nova a8nova mentioned this pull request Jul 8, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants