-
Notifications
You must be signed in to change notification settings - Fork 26.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ConversationalPipeline and Conversation object #31165
Conversation
…een deprecated for some time and are due for removal
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Please make sure there are very solid examples of how to do conversational from now on! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tidying this up!
+1 on @LysandreJik's comment
@osanseviero has been updating some docs in model repos, and I added the sidebar tutorial as well. If there's anywhere else you think it would make sense to add these examples, let me know! |
Merging this - I think it's reasonably safe, but let's see if any more issues turn up before the next release. |
MII legacy tests use `from transformers import Conversation` [here](https://github.com/microsoft/DeepSpeed-MII/blob/c171c4ee290e96c0d3e618b654be8add5eca973b/mii/legacy/method_table.py#L8). Conversation was removed from transformers [here](huggingface/transformers#31165) so we pin to a version before that before unpinning.
MII legacy tests use `from transformers import Conversation` [here](https://github.com/microsoft/DeepSpeed-MII/blob/c171c4ee290e96c0d3e618b654be8add5eca973b/mii/legacy/method_table.py#L8). Conversation was removed from transformers [here](huggingface/transformers#31165) so we pin to a version before that before unpinning.
MII legacy tests use `from transformers import Conversation` [here](https://github.com/microsoft/DeepSpeed-MII/blob/c171c4ee290e96c0d3e618b654be8add5eca973b/mii/legacy/method_table.py#L8). Conversation was removed from transformers [here](huggingface/transformers#31165) so we pin to a version before that before unpinning.
MII legacy tests use `from transformers import Conversation` [here](https://github.com/microsoft/DeepSpeed-MII/blob/c171c4ee290e96c0d3e618b654be8add5eca973b/mii/legacy/method_table.py#L8). Conversation was removed from transformers [here](huggingface/transformers#31165) so we pin to a version before that before unpinning.
* Remove ConversationalPipeline and Conversation object, as they have been deprecated for some time and are due for removal * Update not-doctested.txt * Fix JA and ZH docs * Fix JA and ZH docs some more * Fix JA and ZH docs some more
* Remove ConversationalPipeline and Conversation object, as they have been deprecated for some time and are due for removal * Update not-doctested.txt * Fix JA and ZH docs * Fix JA and ZH docs some more * Fix JA and ZH docs some more
* Remove ConversationalPipeline and Conversation object, as they have been deprecated for some time and are due for removal * Update not-doctested.txt * Fix JA and ZH docs * Fix JA and ZH docs some more * Fix JA and ZH docs some more
* Remove ConversationalPipeline and Conversation object, as they have been deprecated for some time and are due for removal * Update not-doctested.txt * Fix JA and ZH docs * Fix JA and ZH docs some more * Fix JA and ZH docs some more
Both the
ConversationalPipeline
and theConversation
object have been deprecated for a while, and are due for removal in4.42
, which is the upcoming version. This PR removes them and every reference to them that I could find.Fixes #31158