legacy to init the slow tokenizer when converting from slow was wrong #30972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyeroberts
approved these changes
May 22, 2024
| @@ -151,9 +151,6 @@ def __init__( | |||
| self.legacy = legacy | |||
|
|
|||
| if add_prefix_space is not None: | |||
| logger.warning_once( | |||
There was a problem hiding this comment.
It's not helpful and conversion time is fast, and if we save (serialize it) then you have the warning while you shuld not!
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
added a commit
that referenced
this pull request
May 22, 2024
itazap
pushed a commit
that referenced
this pull request
May 24, 2024
itazap
pushed a commit
that referenced
this pull request
May 30, 2024
zucchini-nlp
pushed a commit
to zucchini-nlp/transformers
that referenced
this pull request
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A small nit but the arg was not passed. cc @itazap one fix already 😉