-
Notifications
You must be signed in to change notification settings - Fork 26.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PaliGemma - fix processor with no input text #30916
Conversation
cc @molbap |
Hi @hiyouga , thanks for the fix! LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing!
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Update processing_paligemma.py
Update processing_paligemma.py
Update processing_paligemma.py
Update processing_paligemma.py
Update processing_paligemma.py
Update processing_paligemma.py
What does this PR do?
Fix the paligemma processor raises exception on empty text inputs
Reproduce
The following lines require
text
should be a list, we need to convert the Nonetype input to a string or list firstly.transformers/src/transformers/models/paligemma/processing_paligemma.py
Lines 176 to 179 in 92d1d97
transformers/src/transformers/models/paligemma/processing_paligemma.py
Lines 186 to 198 in 92d1d97
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@amyeroberts