Support for Falcon2-11B #30771
Merged
Support for Falcon2-11B #30771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurZucker
approved these changes
May 13, 2024
There was a problem hiding this comment.
LGTM, let's make the test go green and good to go!
For outside readers, this does not go against the philosophy as the falcon modeling code is already not very much in accordance to our philosophy 😉 (it has a lot of code paths etc).
Not super happy but it's the best compromise for this model
| @@ -602,6 +602,25 @@ def test_lm_generate_falcon(self): | |||
|
|
|||
| self.assertEqual(output_str, EXPECTED_OUTPUT) | |||
|
|
|||
| @slow | |||
| @require_bitsandbytes | |||
| def test_lm_generate_falcon_11b(self): | |||
There was a problem hiding this comment.
thanks for adding a test!
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@ArthurZucker The tests have passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the Falcon2-11B architecture.