Separate tokenizer tests #30675
Merged
Separate tokenizer tests #30675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
LysandreJik
approved these changes
May 7, 2024
zucchini-nlp
pushed a commit
to zucchini-nlp/transformers
that referenced
this pull request
May 10, 2024
* nit * better filter * pipeline tests should only be models/xxx not anything else * nit to better see filtering of the files that are passed to test torch * oups
itazap
pushed a commit
that referenced
this pull request
May 14, 2024
* nit * better filter * pipeline tests should only be models/xxx not anything else * nit to better see filtering of the files that are passed to test torch * oups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Make sure we run the tokenization specific tests in this workflow. Should allow better splitting.
This reduces the
iddletime of the torch/tf/flax jobs. Improving further the time ci take to run.In this PR I make sure that only the tf flax test files are passed to the corresponding tests, but this might not fair well with testing that the tests are protected WDYT?