Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in mlx tensor support #29509

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Typo in mlx tensor support #29509

merged 2 commits into from
Mar 8, 2024

Conversation

pcuenca
Copy link
Member

@pcuenca pcuenca commented Mar 7, 2024

What does this PR do?

#29406 recently added MLX tensor support to BatchEncoding. However, I think there's a typo in _is_mlx when importing the mlx.core module.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

cc @Y4hL for verification

@tidely
Copy link
Contributor

tidely commented Mar 7, 2024

Yeah, it's a typo

@pcuenca pcuenca mentioned this pull request Mar 7, 2024
5 tasks
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@pcuenca pcuenca changed the title Potential typo in mlx support Typo in mlx tensor support Mar 7, 2024
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for fixing!

Reviewing in place of @ArthurZucker as I'm watching the repo now :)

@pcuenca
Copy link
Member Author

pcuenca commented Mar 7, 2024

Merged main to pull 4ed9ae6 and fix the failing test.

@pcuenca
Copy link
Member Author

pcuenca commented Mar 8, 2024

Feel free to merge whenever (I can't do it) :)

@amyeroberts amyeroberts merged commit 631fa7b into huggingface:main Mar 8, 2024
21 checks passed
@pcuenca pcuenca deleted the patch-1 branch March 8, 2024 10:09
itazap pushed a commit that referenced this pull request May 14, 2024
Potential typo in mlx support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants