Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Awq] Add peft support for AWQ #28987

Merged
merged 5 commits into from
Feb 19, 2024

Conversation

younesbelkada
Copy link
Contributor

@younesbelkada younesbelkada commented Feb 13, 2024

What does this PR do?

As per title, adds Trainer + AWQ + PEFT support.
Needs to be merged at the same time as: huggingface/peft#1399
The tests are directly added on huggingface/peft#1399

cc @casper-hansen @pacman100 @amyeroberts

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding!

Only thing to address is the use of the deprecated _is_quantized_training_enabled

src/transformers/quantizers/quantizer_awq.py Outdated Show resolved Hide resolved
src/transformers/quantizers/quantizer_awq.py Outdated Show resolved Hide resolved
@younesbelkada
Copy link
Contributor Author

cc @amyeroberts - we just got a release from autoawq ! this is ready for review 🙏
After merging this, I'll merge huggingface/peft#1399 :)

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great - thanks for updating!

# AWQ does not support neither QAT (Quantization Aware Training or PEFT yet.)
# TODO: if this is supported in the future, do a version check here.
return False
# AWQ supports PEFT fine-tuning from version 0.2.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@younesbelkada younesbelkada merged commit 864c8e6 into huggingface:main Feb 19, 2024
21 checks passed
@younesbelkada younesbelkada deleted the add-awq-peft branch February 19, 2024 00:31
zucchini-nlp pushed a commit to zucchini-nlp/transformers that referenced this pull request Feb 19, 2024
* add peft support for AWQ

* Update src/transformers/quantizers/quantizer_awq.py

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>

* fix

---------

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
@RanchiZhao
Copy link

cool!

itazap pushed a commit that referenced this pull request May 14, 2024
* add peft support for AWQ

* Update src/transformers/quantizers/quantizer_awq.py

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>

* fix

---------

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants