Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs to add the phi-2 example #28392

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

susnato
Copy link
Contributor

@susnato susnato commented Jan 8, 2024

What does this PR do?

This updates the docs as discussed here

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@ArthurZucker

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, not a fan of having to rely on a custom model, but while #28163 is not merged let's have this

@ArthurZucker
Copy link
Collaborator

Can you make it into a tip / warning for the mean time.

@susnato
Copy link
Contributor Author

susnato commented Jan 10, 2024

Hi @ArthurZucker, I have added the tip/warning.

Let me know if anything more needs to be added.

@ArthurZucker
Copy link
Collaborator

just need to rebase on main 😉

@susnato
Copy link
Contributor Author

susnato commented Jan 10, 2024

Sorry my bad 😅

Done!

@ArthurZucker ArthurZucker merged commit fff8ca8 into huggingface:main Jan 10, 2024
7 checks passed
@ArthurZucker
Copy link
Collaborator

Thanks!

staghado pushed a commit to staghado/transformers that referenced this pull request Jan 15, 2024
MadElf1337 pushed a commit to MadElf1337/transformers that referenced this pull request Jan 15, 2024
wgifford pushed a commit to wgifford/transformers that referenced this pull request Jan 21, 2024
AjayP13 pushed a commit to AjayP13/transformers that referenced this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants