Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🔗 Docs] Fixed Incorrect Migration Link #24793

Merged
merged 2 commits into from
Jul 14, 2023
Merged

[🔗 Docs] Fixed Incorrect Migration Link #24793

merged 2 commits into from
Jul 14, 2023

Conversation

kadirnar
Copy link
Contributor

I couldn't find it in transformers files. Can you check? Is it true?

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kadirnar, thanks for opening this PR and contributing.

If you look at the page title in the docs here " Migrate to 🤗 Transformers from pytorch-transformers or pytorch-pretrained-bert" and the one linked to, they are two unrelated migration pages.

To update the link, the equivalent page will need to be found.

@kadirnar
Copy link
Contributor Author

Hi @amyeroberts , I am new to transformes library. I wanted to fix this error that I saw in the documentation. Because the link is broken.

The documentation page MIGRATION doesn't exist in v4.30.0, but exists on the main version. Click here to redirect to the main version of the documentation.

I looked in transformers documentation(https://huggingface.co/docs) and couldn't find it. Can you help?

README.md Outdated Show resolved Hide resolved
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
@kadirnar
Copy link
Contributor Author

Thank you for the help💖

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sgugger sgugger merged commit 5bb4430 into huggingface:main Jul 14, 2023
7 checks passed
@kadirnar kadirnar deleted the fix/incorrect-migration-link branch July 14, 2023 21:50
blbadger pushed a commit to blbadger/transformers that referenced this pull request Nov 8, 2023
* [🔗 Docs] Fixed Incorrect Migration Link

* Update README.md

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>

---------

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants