Fix some is_xxx_available
#23365
Merged
Fix some is_xxx_available
#23365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ydshieh thanks for fixing this and sorry for having introduced these bugs in first place. |
apbard
reviewed
May 15, 2023
| @@ -36,6 +36,7 @@ | |||
| logger = logging.get_logger(__name__) # pylint: disable=invalid-name | |||
|
|
|||
|
|
|||
| # TODO: This doesn't work for all packages (`bs4`, `faiss`, etc.) Talk to Sylvain to see how to do with it better. | |||
There was a problem hiding this comment.
a possibility could be to split the pkg_name arg in two. one for find_spec and the other for metadata, with the default being equal.
There was a problem hiding this comment.
@sgugger Do you have any comment regarding the changes I made in this PR?
There was a problem hiding this comment.
I think it's fine as it is. No need to make _is_package_available more complex since the alternative takes one line.
|
The documentation is not available anymore as the PR was closed or merged. |
sheonhan
pushed a commit
to sheonhan/transformers
that referenced
this pull request
Jun 1, 2023
* fix * fix --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
gojiteji
pushed a commit
to gojiteji/transformers
that referenced
this pull request
Jun 5, 2023
* fix * fix --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
* fix * fix --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
FYI, after #23163,
is_bs4_available()andis_faiss_available()givesFalseeven if they are actually available. This causes some CI errors, in particularly,MarkupLM.This PR fixes the issue in a quick way. It's better to discuss if we want to enhance the function
_is_package_availableto be able to handle such edge cases.(cc. @apbard FYI)