Added type hints for Graphormer pytorch version
#23073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added type hints for graphormers pytorch , checked formating issues .
|
The documentation is not available anymore as the PR was closed or merged. |
|
This looks pretty good! Is there a reason to use |
|
@Rocketknight1 Hi 👋
if still changes are required i would be happy to make it🙂 |
|
Hi @dewasahu2003, I think in most cases we just annotate those types as |
|
@Rocketknight1 Hi 👋
|
|
Yep, I think replacing with LongTensor is slightly better, and does make the code a bit cleaner too. |
Rocketknight1
approved these changes
May 15, 2023
|
Sure |
|
Done. Thanks for the PR, we really appreciate it! |
sheonhan
pushed a commit
to sheonhan/transformers
that referenced
this pull request
Jun 1, 2023
* Added type hints for `Graphormer` pytorch version added type hints for graphormers pytorch , checked formating issues . * made the code less bloated
gojiteji
pushed a commit
to gojiteji/transformers
that referenced
this pull request
Jun 5, 2023
* Added type hints for `Graphormer` pytorch version added type hints for graphormers pytorch , checked formating issues . * made the code less bloated
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
* Added type hints for `Graphormer` pytorch version added type hints for graphormers pytorch , checked formating issues . * made the code less bloated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Rocketknight1 👋
graphormerpytorchif some checks on ci/cd do not, please do comment and correct