-
Notifications
You must be signed in to change notification settings - Fork 26.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(llama): fix LlamaTokenzier #22746
fix(llama): fix LlamaTokenzier #22746
Conversation
Bug in LlamaTokenizer when huggingface#22742
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Good job on the fix 🚀 . Note that the seq and cls token were not even set, was part of the problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix! 🚀
It seems there is an issue with your CircleCI permissions, as the tests won't run.
Could you try refreshing your permissions as shown here?
Thanks for your quick review, I have re-run the CI tests. 🤗 @amyeroberts @ArthurZucker |
Bug in LlamaTokenizer when huggingface#22742
What does this PR do?
Fixes #22742
return_token_type_ids=True
#22742This PR removes an extra
sep
token in the sequence length calculation.Ref:
transformers/src/transformers/models/llama/tokenization_llama.py
Lines 178 to 187 in 7df1343
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.