Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing infinite loop in UnigramTrainer. #1182

Merged
merged 2 commits into from
Mar 15, 2023
Merged

Fixing infinite loop in UnigramTrainer. #1182

merged 2 commits into from
Mar 15, 2023

Conversation

Narsil
Copy link
Collaborator

@Narsil Narsil commented Mar 15, 2023

Fix #1179.

@Narsil Narsil mentioned this pull request Mar 15, 2023
Closed
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 15, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

ArthurZucker
ArthurZucker approved these changes Mar 15, 2023
View reviewed changes
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should we add a simple test to make sure this is the case for other models too?

sgugger
sgugger approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@Narsil
Copy link
Collaborator Author

Narsil commented Mar 15, 2023

LGTM, should we add a simple test to make sure this is the case for other models too?

Ideally yes.
In practice, I'm in low effort maintenance, test that trigger while loops are hard to create and fail correctly I think.

@Narsil Narsil merged commit 5ecd329 into main Mar 15, 2023
@Narsil Narsil deleted the fix_infinite_looping branch March 15, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgugger sgugger sgugger approved these changes

@ArthurZucker ArthurZucker ArthurZucker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UnigramTrainer Stalls on Small Vocabulary Size
4 participants
@Narsil @HuggingFaceDocBuilderDev @sgugger @ArthurZucker