Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding m1 build to the release process for Python. #1055

Merged
merged 2 commits into from
Aug 25, 2022
Merged

Adding m1 build to the release process for Python. #1055

merged 2 commits into from
Aug 25, 2022

Conversation

Narsil
Copy link
Collaborator

@Narsil Narsil commented Aug 25, 2022 •
edited
Loading

@Narsil Narsil requested a review from McPatate August 25, 2022 07:52
McPatate
McPatate approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@McPatate McPatate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! Thanks for taking care of this.

Is it repeatable ? Since the worker isn't cleaned after each run.

Maybe we should add a cleanup task.

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@Narsil
Copy link
Collaborator Author

Narsil commented Aug 25, 2022

Is it repeatable ? Since the worker isn't cleaned after each run.

What do you mean ? The python versions are hard installed in pyenv which makes cleanup not super necessary (the deps are hard upgraded before every run + the checkout means the thing is going to be rebuilt)

This was referenced Aug 25, 2022
Closed
Closed
@Narsil
Copy link
Collaborator Author

Narsil commented Aug 25, 2022

I restarted the jobs, they seem to work.

@Narsil Narsil merged commit c174b5b into main Aug 25, 2022
@Narsil Narsil deleted the m1_build branch August 25, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McPatate McPatate McPatate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prebuilding tokenizers for Mac M1.
3 participants
@Narsil @HuggingFaceDocBuilderDev @McPatate