Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: fix xpu crash brought by code refine. torch.xpu rely on impor… #2337

Closed
wants to merge 4 commits into from

Conversation

sywangyi
Copy link
Contributor

…t ipex

@OlivierDehaene OR @Narsil

…t ipex

Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
@sywangyi
Copy link
Contributor Author

@danieldk please help review and merge

Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
@sywangyi
Copy link
Contributor Author

sywangyi commented Aug 1, 2024

without this PR, the xpu could not work for tgi any more

@yao-matrix
Copy link

@danieldk, could you pls help review? Thx.

@sywangyi
Copy link
Contributor Author

sywangyi commented Aug 7, 2024

also fix the regression brought by recent change, 47447ef#diff-d1fb889c08e1e52e1874c88af90f875aa09624b05f28970c8e8b902e08aa3c50

@sywangyi
Copy link
Contributor Author

sywangyi commented Aug 7, 2024

please help merge it ASAP, or else xpu could no work in latest tgi

@yao-matrix
Copy link

@ke.ding@intel.com

@sywangyi
Copy link
Contributor Author

sywangyi commented Aug 8, 2024

@drbh please help thanks

@drbh drbh mentioned this pull request Aug 8, 2024
@drbh
Copy link
Collaborator

drbh commented Aug 8, 2024

closing as #2379 was merged with these changes

@drbh drbh closed this Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants