Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPTQ CI improvements #2151

Merged
merged 2 commits into from
Jul 5, 2024
Merged

GPTQ CI improvements #2151

merged 2 commits into from
Jul 5, 2024

Conversation

danieldk
Copy link
Member

@danieldk danieldk commented Jul 1, 2024

What does this PR do?

Two related improvements:

  • Add support for manually triggering a release build.
  • Add more representative Llama GPTQ test. The old test is kept around (but renamed) since it tests the format produced by text-generation-server quantize.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

The Llama GPTQ test is updated to use a model with the commonly-used
quantizer config format and activation sorting. The old test is
kept around (but renamed) since it tests the format produced by
`text-generation-server quantize`.
@danieldk danieldk force-pushed the ci/better-gptq-testing branch 7 times, most recently from b9d3e0a to 532b899 Compare July 1, 2024 18:47
@danieldk
Copy link
Member Author

danieldk commented Jul 4, 2024

@danieldk danieldk marked this pull request as ready for review July 4, 2024 06:30
@danieldk danieldk requested a review from Narsil July 4, 2024 14:09
Copy link
Collaborator

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danieldk danieldk merged commit 67ef064 into main Jul 5, 2024
14 checks passed
@danieldk danieldk deleted the ci/better-gptq-testing branch July 5, 2024 12:12
ErikKaum pushed a commit that referenced this pull request Jul 26, 2024
* Add more representative Llama GPTQ test

The Llama GPTQ test is updated to use a model with the commonly-used
quantizer config format and activation sorting. The old test is
kept around (but renamed) since it tests the format produced by
`text-generation-server quantize`.

* Add support for manually triggering a release build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants