Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set maximum grpc message receive size to 2GiB #2075

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

danieldk
Copy link
Member

@danieldk danieldk commented Jun 17, 2024

What does this PR do?

Set maximum grpc message receive size to 2GiB. The previous default was 4MiB, which doesn't really work well for multi-modal models.

Fixes #2018

Also bump Rust version to make CI work again.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@danieldk danieldk force-pushed the maintenance/grpc-2gib-recieve branch 2 times, most recently from 691d4fd to 30a3842 Compare June 17, 2024 12:52
The previous default was 4MiB, which doesn't really work well for
multi-modal models.
@danieldk danieldk force-pushed the maintenance/grpc-2gib-recieve branch from 30a3842 to 55227eb Compare June 17, 2024 13:06
@danieldk danieldk marked this pull request as ready for review June 17, 2024 13:07
@danieldk danieldk merged commit c8c7ccd into main Jun 17, 2024
5 of 6 checks passed
@danieldk danieldk deleted the maintenance/grpc-2gib-recieve branch June 17, 2024 14:40
@Narsil Narsil mentioned this pull request Jun 24, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant