Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the torch_dtype and quant_storage_dtype #1614

Merged
merged 2 commits into from
Apr 4, 2024
Merged

fix the torch_dtype and quant_storage_dtype #1614

merged 2 commits into from
Apr 4, 2024

Conversation

pacman100
Copy link
Contributor

@pacman100 @galtay
fix the torch_dtype and quant_storage_dtype
6e43bd5 
Co-Authored-By: Gabriel Altay <gabriel.altay@gmail.com>
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@BenjaminBossan
Copy link
Member

Could you please fix the code quality issue?

BenjaminBossan
BenjaminBossan approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this fix, Sourab, and thanks @galtay for the investigation and proposal. From my perspective, this can be merged if @galtay can confirm that this solves the issue.

@pacman100 pacman100 merged commit 8452d71 into main Apr 4, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galtay galtay galtay approved these changes

@BenjaminBossan BenjaminBossan BenjaminBossan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

examples/sft/run_peft.sh model load dtype error
4 participants
@pacman100 @HuggingFaceDocBuilderDev @BenjaminBossan @galtay