Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests expected environment variable name #2059

Merged
merged 6 commits into from
Oct 15, 2024
Merged

Fix tests expected environment variable name #2059

merged 6 commits into from
Oct 15, 2024

Conversation

echarlaix
Copy link
Collaborator

@echarlaix echarlaix commented Oct 14, 2024 •
edited
Loading

needed by test_load_model_from_hub_private which was previously always skipped

optimum/tests/onnxruntime/test_modeling.py

Line 974 in 9fd9ca5

token = os.environ.get("HF_HUB_READ_TOKEN", None)

regisss
regisss approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@echarlaix echarlaix merged commit d11e285 into main Oct 15, 2024
45 of 46 checks passed
@echarlaix echarlaix deleted the fix-env-name branch October 15, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@regisss regisss regisss approved these changes

@IlyasMoutawwakil IlyasMoutawwakil Awaiting requested review from IlyasMoutawwakil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@echarlaix @regisss