Upgrade macOS image for tests compatibility with numpy v2 #2055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echarlaix
force-pushed
the
macos-workflow
branch
from
26e02aa
to
c9990ac
Compare
echarlaix
changed the title
|
thanks ! yes many errors with old macos, we might also wanna drop python 3.8 as it's already EOL |
IlyasMoutawwakil
approved these changes
Oct 11, 2024
|
no more |
Yes for python 3.8 I wanted to tackle it for all workflows at once but will include it in this one so we're all good, thanks @IlyasMoutawwakil |
Co-authored-by: Ilyas Moutawwakil <57442720+IlyasMoutawwakil@users.noreply.github.com>
Co-authored-by: Ilyas Moutawwakil <57442720+IlyasMoutawwakil@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix :
https://github.com/huggingface/optimum/actions/runs/11290608247/job/31402830526
https://github.com/huggingface/optimum/actions/runs/11290608260/job/31402830356